RFR: 8310874: Runthese30m crashes with klass should be in the placeholders during verification
Coleen Phillimore
coleenp at openjdk.org
Tue Aug 1 17:55:58 UTC 2023
On Mon, 31 Jul 2023 14:44:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 901:
>>
>>> 899: // class loaders, handle parallel define requests. In this case, find_or_define_instance_class may return a different
>>> 900: // InstanceKlass, in which case the old k would be deallocated
>>> 901: k = find_or_define_instance_class(h_name, class_loader, k, CHECK_NULL);
>>
>> Now that you call this for parallel-capable and non-parallel-capable loaders the comments preceding the definition of `find_or_define_instance_class` no longer make complete sense.
>
> This comment is still true. non bootstrap parallel-capable class loaders might return a different k.
Edit. yes this comment repeats what find_or_define_instance_class already says later on, so doesn't really add anything here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14889#discussion_r1279442968
More information about the hotspot-runtime-dev
mailing list