RFR: 8309240: Array classes should be stored in dynamic CDS archive [v7]

Calvin Cheung ccheung at openjdk.org
Tue Aug 1 21:54:05 UTC 2023


On Tue, 1 Aug 2023 19:13:10 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes in systemDictionaryShared.cpp; remove extra line in metaspaceShared.cpp
>
> src/hotspot/share/cds/dynamicArchive.cpp line 400:
> 
>> 398: 
>> 399: GrowableArray<ObjArrayKlass*>* DynamicArchive::_array_klasses = nullptr;
>> 400: Array<ObjArrayKlass*>* DynamicArchive::_dynamic_archive_array_klasses = nullptr;
> 
> Perhaps a comment to clarify that `_array_klasses` and `_dynamic_archive_array_klasses` only hold the array classes which have element class in static archive would be useful when reading the code later.

I've added a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1281187565


More information about the hotspot-runtime-dev mailing list