Integrated: 8309240: Array classes should be stored in dynamic CDS archive

Calvin Cheung ccheung at openjdk.org
Tue Aug 1 22:11:57 UTC 2023


On Thu, 20 Jul 2023 16:47:10 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Please review this RFE for adding array classes in the dynamic CDS archive.
> 
> During dynamic dump, only the array classes with the `element_klass` already in the static archive will be stored in the dynamic archive. See `ArchiveBuilder::gather_array_klasses()`. It is because the array classes which are in the same archive (either static or dynamic) are already "connected" together. Higher dimension primitive array classes are also stored in the dynamic archive. Note that one-dimensional primitive array classes are store in the static archive.
> 
> During runtime, the `DynamicArchive::setup_array_klasses()` is for setting up the array classes. If only the `bottom_klass` is in the static archive, the function will point the `array_klasses` to the stored array classes in the dynamic archive. If a lower dimension array class is already in the static archive, its `higher_dimension` will be set to refer to the stored array classes in the dynamic archive.
> 
> Some logging is added to `ObjArrayKlass::array_klass(int n, TRAPS)` to indicate an array class is being loaded from the archive.
> 
> Passed tiers 1 - 4 testing.

This pull request has now been integrated.

Changeset: dc142470
Author:    Calvin Cheung <ccheung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dc142470773ba53b06d424f489d5f1919b2d713b
Stats:     339 lines in 12 files changed: 323 ins; 5 del; 11 mod

8309240: Array classes should be stored in dynamic CDS archive

Reviewed-by: iklam

-------------

PR: https://git.openjdk.org/jdk/pull/14959


More information about the hotspot-runtime-dev mailing list