RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
Stefan Karlsson
stefank at openjdk.org
Wed Aug 2 07:56:54 UTC 2023
On Mon, 24 Jul 2023 09:02:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> The flag newly added by [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) is prompting the use of `-XX:+DisableTHPStackMitigation` to disable the THP stack mitigation, thus allowing THP in thread stacks. This double negation does not read well, and not in line with other mitigation flags like `IntelJccErratumMitigation`.
>
> It would be better to rename the flag to avoid double-negation, before it proliferates to other JDK releases.
>
> (I would have the same comment during the original review, but missed it :P)
>
> Additional testing:
> - [ ] GHA
> - [x] Linux x86_64 fastdebug, affected test
FWIW, I agree with Aleksey and I don't think we should be adding flags prefixed with Disable.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14992#issuecomment-1661693518
More information about the hotspot-runtime-dev
mailing list