RFR: 8304292: Memory leak related to ClassLoader::update_class_path_entry_list [v2]

[David Holmes]

On Thu, 3 Aug 2023 22:09:48 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this small fix for `ClassPathEntry` leak when there's a duplicate entry in the app class path (`-cp`) and the `check_for_duplicate` argument is set to `true`, the `ClassLoader::add_to_app_classpath_entries` function should delete the entry before returning. This fix also corrects the call to `update_class_path_entry_list` from `setup_app_search_path`; the `check_for_duplicate` argument should be set to `true`. Two test cases are included to exercise the code path.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comments to boolean args

Thanks for the comments.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15132#pullrequestreview-1561972376