RFR: 8313435: Clean up unused default methods code [v5]

[Coleen Phillimore]

On Thu, 3 Aug 2023 12:25:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Default methods processing code has unused code (that gets -Wconversion warnings) from when it was used to create bridge (called overpass) method for an early implementation of generic reification in Hotspot.
>> 
>> This change removes unused bytecodeAssembler code and adds a check for methods and constant pool overflow.
>> Tested with tier1 and runtime/lambda-features tests.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make assert an exception.

There's no ability to pre-check because we don't know how long the constant pool buffer is going to get until we generate the instructions that potentially add entries to the constant pool.  Then we know.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15095#issuecomment-1665683424