RFR: JDK-8306441: Two phase segmented heap dump [v26]

[Yi Yang]

On Fri, 4 Aug 2023 16:31:28 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   new can_parallel_dump
>
> test/hotspot/jtreg/serviceability/dcmd/gc/HeapDumpParallelTest.java line 59:
> 
>> 57:         out.shouldContain("Heap dump file created");
>> 58:         if (!expectSerial && Runtime.getRuntime().availableProcessors() > 1) {
>> 59:             Asserts.assertTrue(app.getProcessStdout().contains("Dump heap objects in parallel"));
> 
> I think we just need these other asserts converted to shouldContain, and the assertFalse changed to shouldNotContain.
> This might be a annoying, but if you get the test failing and don't get the actual output, that's worse. 8-)
> Maybe we can aim to integrate on Monday.

getProcessStdout is actually a string instead of OutputAnalyzer, its name is somewhat deceptive

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13667#discussion_r1284662958