RFR: JDK-8299790: os::print_hex_dump is racy [v2]

[David Holmes]

On Mon, 17 Jul 2023 18:39:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Tiny fix for a tiny problem. 
>> 
>> `os::print_hex_dump` uses `os::is_readable_pointer` to check the to-be-printed memory for readability; `os::is_readable_pointer` uses `SafeFetch` to probe the memory for access, which is good, but then, by the time we actually print that information, we reread the memory location again. It may be unreadable now (either because the region had been unmapped or protected by a concurrent thread), and we would crash the VM.
>> 
>> The patch rewrites the function to not use `os::is_readable_pointer`, but to use `SafeFetch` to read from memory directly and then use the result of that read for printing. That requires a bit of bit fiddling, since we only can read word-wise, but the hex-dump could be in units between bytes and qwords.
>> 
>> Tests: manual and GHA-driven gtests on all platforms. The gtests test this function exhaustively.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   feedback Aleksey; small code reshuffle

Seems reasonable. Just one (hopefully) minor thing below.

Thanks.

test/hotspot/gtest/runtime/test_os.cpp line 37:

> 35: #include "utilities/ostream.hpp"
> 36: #include "unittest.hpp"
> 37: #include "gmock/gmock.h"

Is this a leftover?

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14895#pullrequestreview-1564601549
PR Review Comment: https://git.openjdk.org/jdk/pull/14895#discussion_r1285411297