RFR: JDK-8312469: Print huge page information in error reporting

David Holmes dholmes at openjdk.org
Mon Aug 7 06:30:31 UTC 2023


On Thu, 20 Jul 2023 15:38:38 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> The new printout is also less wordy

Is it? The old printout had one line to shows all available pagesizes whilst the new has one line per available pagesize.

I'm not sure replacing the existing output is the right thing to do though ...

src/hotspot/os/linux/os_linux.cpp line 2149:

> 2147:   _print_ascii_file_h("/sys/kernel/mm/transparent_hugepage/enabled",
> 2148:                       "/sys/kernel/mm/transparent_hugepage/enabled", st);
> 2149:   _print_ascii_file_h("/sys/kernel/mm/transparent_hugepage/defrag (defrag/compaction efforts parameter)",

Is it not still interesting to see these kernel values?

-------------

PR Review: https://git.openjdk.org/jdk/pull/14958#pullrequestreview-1564620279
PR Review Comment: https://git.openjdk.org/jdk/pull/14958#discussion_r1285422733


More information about the hotspot-runtime-dev mailing list