RFR: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation [v2]
Thomas Stuefe
stuefe at openjdk.org
Mon Aug 7 09:08:32 UTC 2023
On Mon, 7 Aug 2023 07:19:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The flag newly added by [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) is prompting the use of `-XX:+DisableTHPStackMitigation` to disable the THP stack mitigation, thus allowing THP in thread stacks. This double negation does not read well, and not in line with other mitigation flags like `IntelJccErratumMitigation`.
>>
>> It would be better to rename the flag to avoid double-negation, before it proliferates to other JDK releases.
>>
>> (I would have the same comment during the original review, but missed it :P)
>>
>> Additional testing:
>> - [ ] GHA
>> - [x] Linux x86_64 fastdebug, affected test
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8312585-rename-thp-mitigation
> - Fix
Good.
Thanks to @dholmes-ora for resolving the discussions, I'm happy we agree.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14992#pullrequestreview-1564883546
More information about the hotspot-runtime-dev
mailing list