Integrated: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
Aleksey Shipilev
shade at openjdk.org
Mon Aug 7 10:47:41 UTC 2023
On Mon, 24 Jul 2023 09:02:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> The flag newly added by [JDK-8312182](https://bugs.openjdk.org/browse/JDK-8312182) is prompting the use of `-XX:+DisableTHPStackMitigation` to disable the THP stack mitigation, thus allowing THP in thread stacks. This double negation does not read well, and not in line with other mitigation flags like `IntelJccErratumMitigation`.
>
> It would be better to rename the flag to avoid double-negation, before it proliferates to other JDK releases.
>
> (I would have the same comment during the original review, but missed it :P)
>
> Additional testing:
> - [x] GHA
> - [x] Linux x86_64 fastdebug, affected test
This pull request has now been integrated.
Changeset: 226cdc69
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/226cdc696d933fbc174d07b0d9817246dbc0e06c
Stats: 12 lines in 3 files changed: 2 ins; 2 del; 8 mod
8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
Reviewed-by: dholmes, stuefe
-------------
PR: https://git.openjdk.org/jdk/pull/14992
More information about the hotspot-runtime-dev
mailing list