RFR: 8313435: Clean up unused default methods code [v6]

[Coleen Phillimore]

On Fri, 4 Aug 2023 14:28:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Default methods processing code has unused code (that gets -Wconversion warnings) from when it was used to create bridge (called overpass) method for an early implementation of generic reification in Hotspot.
>> 
>> This change removes unused bytecodeAssembler code and adds a check for methods and constant pool overflow.
>> Tested with tier1 and runtime/lambda-features tests.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change to checked_cast<>

There is no reason not to check for an unlikely case of overflow here.  If we do have overflow, throwing an exception is better than asserting.  This is a safety check to replace silently ignoring this overflow and returning the wrong value.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15095#issuecomment-1667724275