RFR: 8311648: Refactor the Arena/Chunk/ChunkPool interface [v7]

[Johan Sjölen]

On Wed, 9 Aug 2023 07:17:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into rework-arena
>>  - Merge remote-tracking branch 'origin/master' into rework-arena
>>  - Found the bug!
>>  - Is it just a missing include?
>>  - Separate assignment
>>  - Accidentally deleted a constructor
>>  - Make Chunk NONCOPYABLE
>>  - Fix style issues
>>  - Dleete chunks
>>  - Merge remote-tracking branch 'origin/master' into rework-arena
>>  - ... and 11 more: https://git.openjdk.org/jdk/compare/c1f4595e...c688bb55
>
> src/hotspot/share/memory/arena.cpp line 277:
> 
>> 275: 
>> 276:   Chunk* k = _chunk;            // Get filled-up chunk address
>> 277:   _chunk = ChunkPool::allocate_chunk(len, alloc_failmode);
> 
> Odd that we would fatal out if init chunk cannot be allocated, and here we leave the OOM behavior to the caller. Is this ever called with anything else than exit_oom?

Looking at the callers: No, we don't, but I think changing this API would go under a different PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14803#discussion_r1288368879