RFR: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) [v3]

[Thomas Stuefe]

On Mon, 31 Jul 2023 21:49:06 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

>> This change is as an alternate solution to my original proposal for [JDK-8312180](https://bugs.openjdk.org/browse/JDK-8312180).
>> 
>> Suggested by @tstuefe.
>> 
>> This change matches the return value of Bits.pageSize with the system page size (which is not currently true on AIX).
>> 
>> These tests are upstream of my target test (TestByteBuffer) and results are encouraging. Tier1 testing ~in ongoing for this change~ passes with flying colours.
>
> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Removes include unistd & replaces it with util/globalDefs.hpp
>  - Replace os::vm_page_size call with sysconf(_SC_PAGESIZE) on AIX in javaClasses.cpp

Looks good. The real question is whether you find any followup problems now that the illusion is partly broken.

Well, it had been broken before, hence the original issue :-/

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14963#pullrequestreview-1571354810