RFR: 8311648: Refactor the Arena/Chunk/ChunkPool interface [v8]

Coleen Phillimore coleenp at openjdk.org
Fri Aug 11 01:30:28 UTC 2023


On Fri, 11 Aug 2023 01:16:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Mention that it's null-terminated
>>  - Comments etc
>
> src/hotspot/share/memory/arena.cpp line 149:
> 
>> 147:     chunk = (Chunk*)p;
>> 148:   }
>> 149:   ::new(chunk) Chunk(length);
> 
> You need to do this because if you find and take a chunk out of the pool, it's not properly initialized?

Okay, I read the code before the comments in the PR, so that answers my question.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14803#discussion_r1290814905


More information about the hotspot-runtime-dev mailing list