RFR: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Aug 11 18:06:59 UTC 2023


On Fri, 11 Aug 2023 17:28:58 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi all, @tstuefe 
>> 
>> Could anyone review this fix for a test failure that could happen on machines with many cores? This fix caps `-XX:ActiveProcessorCount` to 64, which limits the number of internal threads the JVM creates.
>> 
>> An alternative is to bump up the `acceptableRSSLimitMB` such as increasing `basicRSSOverheadMB`. However, this approach could be fragile for machines with even more number of cores (e.g. 256 or more).
>> 
>> -Man
>
> Man Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Always set ActiveProcessorCount=2 instead

Sure, makes sense. I completely overlooked that number of threads can vary dep. on context.

Thanks for investigating.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15241#pullrequestreview-1574149440


More information about the hotspot-runtime-dev mailing list