RFR: 8314020: Print instruction blocks in byte units

[Thomas Stuefe]

On Fri, 11 Aug 2023 18:09:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> > Is there any reason to retain the "unitsize" argument in os::print_instructions? I don't find any remaining uses of it.
> 
> 
> 
> Good question! I went back and forth on this. First, I wanted to keep other callers happy, in case _some_ arch would still want to do larger than 1-byte unit. On the other hand, this is not a generic `print_hex_dump`, we might as well drop the unit size. On the yet another hand, it is a single-line change, so it does not improve readability all that much. So... keeping the default argument seems a safe bet?

Ok, sure. I leave it up to you, I can live with both variants.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15211#issuecomment-1675248958