RFR: 8311981: Test gc/stringdedup/TestStringDeduplicationAgeThreshold.java#ZGenerational timed out [v2]

[David Holmes]

On Mon, 14 Aug 2023 08:29:56 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
>> Member
> 
> Looking at it again. Because this is a gc thread which is not a JavaThread it will not do handshakes (process_if_requested when calling `Monitor::wait`) so the GC thread will progress as long as no JavaThread stalls (locks on handshake locks) with the VMOperation_lock held. This change should fix this. As it is released before `process_if_requested`. So the deadlock should be avoided. Unless there are other paths which leads to handshake locks being taken under the `VMOperation_lock`

Thanks @xmas92 for explaining what happens after the current issue gets resolved.

Thanks for the reviews @stefank , @pchilano, @dcubed-ojdk  and @robehn .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15240#issuecomment-1678076676