RFR: JDK-8312018: Improve reservation of class space and CDS [v4]

Ioi Lam iklam at openjdk.org
Tue Aug 15 06:03:08 UTC 2023


On Tue, 15 Aug 2023 05:45:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> It's unclear which part of the implementation `(MAX2(os::vm_allocation_granularity(), 16 * M))` is "Determined by sysctl vm.mmap_min_addr`.
>> 
>> Do you mean:
>> 
>> - On Linux the lower limit is usually 64KB. While it can be configured via `sysctl vm.mmap_min_addr`, that's rarely done.
>> - We picked a 16MB minimum just to be safe.
>
> Exactly.

I would suggest rewording/simplifying the comment to something like what I said above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15041#discussion_r1294224917


More information about the hotspot-runtime-dev mailing list