RFR: JDK-8307356: Metaspace: simplify BinList handling [v3]

Thomas Stuefe stuefe at openjdk.org
Thu Aug 17 11:50:35 UTC 2023


On Tue, 23 May 2023 15:36:45 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback David
>
> src/hotspot/share/memory/metaspace/metaspaceArena.cpp line 249:
> 
>> 247: 
>> 248:   // Primary allocation
>> 249:   p = allocate_inner(raw_word_size);
> 
> Why wasn't this always raw_word_size which seems to be the aligned size based on the requested word size? ('aligned' might be a better word than 'raw' here)  If I'm reading it correctly.

I think it was a plain oversight.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13776#discussion_r1297106848


More information about the hotspot-runtime-dev mailing list