RFR: JDK-8313781: Add regression tests for large page logging and user-facing error messages [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Aug 17 14:40:57 UTC 2023
On Thu, 17 Aug 2023 12:42:08 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages' of github.com:tstuefe/jdk into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
>> - skip empties
>>
>> Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
>> - Remove THPmode unknown
>> - Several test fixes
>> - erge branch 'master' into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
>> - JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
>
> Great amount of testing, thanks!
>
> I also made 3 more suggestions as the other one for the else ifs. Forgot that one could integrate them directly so just did one last time.
Thanks @kstefanj !
Took over your suggestions, they make the code look cleaner.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15159#issuecomment-1682401698
More information about the hotspot-runtime-dev
mailing list