RFR: 8311222: strace004 can fail due to unexpected stack length after JDK-8309408
Alan Bateman
alanb at openjdk.org
Fri Aug 18 08:13:26 UTC 2023
On Thu, 17 Aug 2023 16:26:15 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The [JDK-8309408](https://bugs.openjdk.org/browse/JDK-8309408) introduced sleepNanos and the tests expected stack is updated.
> The "jdk.internal.event.ThreadSleepEvent.<init>" was added just because I hit this issue while testing fix.
Yes, the stack depth increased so I think this change is okay. Pre-testing of JDK-8309408 did of course run this test 100 times wasn't seen. As a general point, I would really like to see these tests replaced with something less tied to the implementation as it's a tax on anyone that touches the code.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15332#pullrequestreview-1584075542
More information about the hotspot-runtime-dev
mailing list