RFR: 8310874: Runthese30m crashes with klass should be in the placeholders during verification [v3]

[David Holmes]

On Mon, 31 Jul 2023 15:05:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> What would make more sense is find_or_define_instance_class was renamed define_instance_class (which actually handled the AllowParallelDefine logic without bothering the caller about it).
>
> maybe not.  It does return a 'k' and the comment explains why.

My point is that this:

// If a class loader supports parallel classloading handle parallel define requests.
// find_or_define_instance_class may return a different InstanceKlass
InstanceKlass* SystemDictionary::find_or_define_instance_class(Symbol* class_name, Handle class_loader,
                                                               InstanceKlass* k, TRAPS) {

makes it seem like this method is only for parallel-capable loaders when that is no longer true. The same goes for the large comment block ahead of `find_or_define_helper`. These methods do not document how they work for non-parallel-capable loaders.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14889#discussion_r1299578213