RFR: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"

[Calvin Cheung]

On Mon, 21 Aug 2023 18:35:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Looks good to me with a small nit for the test case.
> 
> Also, can we remove the `SharedClassPathEntry::is_signed()` API as well?

Yes, I will also remove the `signed_jar_entry` enum.

> test/hotspot/jtreg/runtime/cds/appcds/JarBuilder.java line 265:
> 
>> 263:     static final String jarSigner = JDKToolFinder.getJDKTool("jarsigner");
>> 264: 
>> 265:     public static void signJarWithDisabledAlg(String jarName) throws Exception {
> 
> I would suggest using full spelling of `signJarWithDisabledAlgorithm`

Fixed. Also removed an extra import from the test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15339#issuecomment-1686995070
PR Review Comment: https://git.openjdk.org/jdk/pull/15339#discussion_r1300612053