RFR: 8298992: runtime/NMT/SummarySanityCheck.java failed with "Total commi…tted (MMMMMM) did not match the summarized committed (NNNNNN)

[Afshin Zafari]

On Mon, 21 Aug 2023 17:33:24 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> The loop in `copy_to` seems to only exit if no-one allocated memory while the loop was busy. Should we consider adding some max loop counter to bail out if some threshold was reached?
> 
> I am a bit uncomfortable with a loop here that in theory might never terminate even if in practice your testing reveals no issue. Just wanted to raise this issue, not 100% sure it needs to be addressed.

I am agree with you. The loop is limited now. Thanks.

> src/hotspot/share/services/mallocTracker.hpp line 194:
> 
>> 192:     // buffer in make_adjustment().
>> 193:     ThreadCritical tc;
>> 194:     size_t total_mallocs;
> 
> Can we rename from `total_mallocs` to `total_size`? When I looked at the code at first I thought we were counting here the number of malloc operations.

Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15306#issuecomment-1687771073
PR Review Comment: https://git.openjdk.org/jdk/pull/15306#discussion_r1301292695