RFR: 8314684: Add overview docs to loaderConstraints.cpp [v2]

David Holmes dholmes at openjdk.org
Tue Aug 22 11:15:29 UTC 2023


On Mon, 21 Aug 2023 22:59:11 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> I added some documentation to make it easier to understand loaderConstraints.cpp. Please review and check if my description is actually correct. Thanks!
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung comments

Well it reads really well and is informative, but is it correct? Hard to evaluate. It would be clearer if the commentary tied into the code more so that I knew where to see each of the things mentioned, and also understand how the different types (LoaderConstraint, ConstraintSet) fit in that description.

Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15372#pullrequestreview-1589188080


More information about the hotspot-runtime-dev mailing list