RFR: 8298992: runtime/NMT/SummarySanityCheck.java failed with "Total commi…tted (MMMMMM) did not match the summarized committed (NNNNNN)

[Thomas Stuefe]

On Tue, 22 Aug 2023 15:02:01 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/hotspot/share/services/mallocTracker.hpp line 205:
>> 
>>> 203:       }
>>> 204:     } while(s->_all_mallocs.size() != total_size && ++loop_counter < loop_limit);
>>> 205:     assert(s->_all_mallocs.size() == total_size, "Total != sum of parts");
>> 
>> Preexisting, but could you please move this to the cpp file? It should not live in the header.
>> 
>> Also I'm not sure the assert is really useful. Won't that be just a source for very rare intermittent errors? What would be the action we take if that assert fires, increase the loop count?
>
> We copy `MemoryCounter` by value, not reference:
> 
> `s->_all_mallocs = _all_mallocs;`
> 
> where `_all_mallocs` is `MemoryCounter`, not  `*MemoryCounter`, so that assert can never trigger, right?
> 
> I mean, even if more memory gets allocated between when we exit the loop and assert, `_all_mallocs.size()` might change, but `s->_all_mallocs.size()` is frozen in time, isn't it?
> 
> So I agree that the assert is not helpful here, but it's because it will never trigger.

I thought the point was to compare the accumulated sum with the running total kept in _all_mallocs?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15306#discussion_r1301860957