RFR: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs [v2]

Yasumasa Suenaga ysuenaga at openjdk.org
Wed Aug 23 01:44:18 UTC 2023


On Wed, 23 Aug 2023 01:24:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.cpp line 56:
> 
>> 54: volatile int             PerfMemory::_initialized = 0;
>> 55: PerfDataPrologue*        PerfMemory::_prologue = nullptr;
>> 56: volatile int             PerfMemory::_destroyed = 0;
> 
> Why was this changed to int?

In my original patch (pasted into JBS), I changed it to `int` because atomic operation only supports integer type only (maybe). So we can keep `bool` if we don't need atomic operations here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302353770


More information about the hotspot-runtime-dev mailing list