RFR: 8314684: Add overview docs to loaderConstraints.cpp [v3]

[David Holmes]

On Wed, 23 Aug 2023 02:31:48 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - added references to source code
>>  - added info about ConstraintSet
>
> src/hotspot/share/classfile/loaderConstraints.cpp line 84:
> 
>> 82: // Otherwise if both LoaderConstraints have different values for _klass, a LinkageError is thrown.
>> 83: //
>> 84: // Otherwise the two LoaderConstraints are merged into one.
> 
> So I looked in `LoaderConstraintTable::add_entry` to see how this algorithm applied and I could not figure out what condition is actually left (regarding `pp1` and `pp2`) when we get to the merge case at L396 ???

Never mind I see it now: `pp1` != `pp2` and neither is null.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15372#discussion_r1302395033