RFR: 8313708: NMT: cleanup _mst_marker

[Gerard Ziemski]

On Wed, 23 Aug 2023 08:46:59 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> One comment but this definitely looks like a nice improvement now, I want to read the surrounding code in a bit more depth before committing to the approval, thanks for the good work :).

Thank you for the feedback.

> src/hotspot/share/services/mallocSiteTable.cpp line 118:
> 
>> 116:  *  Under any of above circumstances, caller should handle the situation.
>> 117:  */
>> 118: MallocSite* MallocSiteTable::lookup_or_add(const NativeCallStack& key, uint16_t* bucket_idx, uint16_t* bucket_pos, MEMFLAGS flags) {
> 
> Could it take a `BucketInfo*` instead of the two separate pointers?

Maybe? I don't know how though since `BucketInfo` fields are `const` so once constructed, the fields can not change.

But I am open to suggestions here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15145#issuecomment-1690191479
PR Review Comment: https://git.openjdk.org/jdk/pull/15145#discussion_r1303208218