RFR: JDK-8313319: [linux] mmap should use MAP_FIXED_NOREPLACE if available [v3]

Thomas Stuefe stuefe at openjdk.org
Thu Aug 24 05:22:00 UTC 2023


On Wed, 23 Aug 2023 22:23:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - feedback david
>>  - Merge branch 'master' into JDK-8313319-MAP_FIXED_NOREPLACE
>>  - Merge branch 'openjdk:master' into JDK-8313319-MAP_FIXED_NOREPLACE
>>  - DK-8313319-MAP_FIXED_NOREPLACE
>
> src/hotspot/os/linux/os_linux.cpp line 3494:
> 
>> 3492:   // Since Linux 4.17, the kernel offers MAP_FIXED_NOREPLACE. With this flag, if a pre-
>> 3493:   // existing mapping exists, the kernel will not map at an alternative point but instead
>> 3494:   // return an error. We can therefore save that unnecassary mmap-munmap cycle.
> 
> unnecessary is still mis-spelt.

Thank you, David, for review and testing. I fixed the typo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15170#discussion_r1303812746


More information about the hotspot-runtime-dev mailing list