RFR: 8298992: runtime/NMT/SummarySanityCheck.java failed with "Total commi…tted (MMMMMM) did not match the summarized committed (NNNNNN)

Gerard Ziemski gziemski at openjdk.org
Fri Aug 25 15:31:11 UTC 2023


On Wed, 16 Aug 2023 12:18:35 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> During exhaustive tests, it is observed that during taking snapshot of NMT metrics it is possible that new allocations happen concurrently, although a `ThreadCritical` is used during copying current metrics to the snapshot.
> A loop is surrounding the copying and checks whether the copied and original are the same.

Marked as reviewed by gziemski (Committer).

OK, this fix looks good to me then as is.

Thank you for fixing this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15306#pullrequestreview-1595963745
PR Comment: https://git.openjdk.org/jdk/pull/15306#issuecomment-1693543053


More information about the hotspot-runtime-dev mailing list