RFR: 8313708: NMT: cleanup _mst_marker

[Gerard Ziemski]

On Thu, 3 Aug 2023 18:44:43 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> While learning the NMT code I came across _mst_marker and I don't really like how it combines 16bit index and 16bit position into single 32bit mst_marker using bit sizzling.
> 
> Consequently, right now we need the following 3 APIs: build_marker(), bucket_idx_from_marker(), pos_idx_from_marker() to support this. They are really not adding any value, in my opinion, and in fact obfuscate the code.
> 
> I'd like to propose that we simplify the code and pass a struct value (as suggested by Thomas) which hides away the 2 individual fields that are implementation detail.

Thank you Johan and Afshin for your reviews!

I'm going to wait with checking this in until after the dust settles with JDK-8315378 though.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15145#issuecomment-1701210891
PR Comment: https://git.openjdk.org/jdk/pull/15145#issuecomment-1701212606