RFR: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935

[Jiangli Zhou]

On Sat, 2 Dec 2023 17:15:57 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> In the fix for the following bug:
> 
> [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
> 
> JvmtiThreadState::state_for_while_locked() was changed to
> return nullptr for attaching JNI threads regardless of whether
> that JNI thread/JavaThread had a java.lang.Thread object.
> 
> We should only filter out a JavaThread that's attaching via JNI
> if it has no java.lang.Thread object.
> 
> This fix has been tested with Mach5 Tier[1-7] and there are no related test failures.
> Mach5 Tier8 is in process.
> 
> I'm going to need @jianglizhou to rerun her testing for:
> 
> [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
> 
> since the test(s) for that fix are not yet integrated in the jdk/jdk repo.

@dcubed-ojdk Thanks for the notification. I just ran one of our affected test 100 times with JDK-8312174 change rolled back and with both following applied:

- https://git.openjdk.org/jdk/pull/16642
- https://github.com/openjdk/jdk/pull/16934

All 100 runs passed without failure. I'm going to run all tests tonight, will report back later tomorrow if I see any issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16934#issuecomment-1837858621