RFR: 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr"

[Daniel D. Daugherty]

On Mon, 4 Dec 2023 16:43:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Please review this trivial change to fix the test to expect that the TempSymbol refcount is 1 more than expected.  The symbol is cached in [JDK-8315559](https://bugs.openjdk.org/browse/JDK-8315559) Delay TempSymbol cleanup to avoid symbol table churn.
> 
> A late change in the review removed draining the queue periodically, which caused this test failure.
> Tested locally.

Thumbs up. This is a trivial fix.

As David likes to say... the proof is in the testing. Thanks for running Mach5 Tier2.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java line 94:

> 92:         OutputAnalyzer output = CDSTestUtils.executeAndLog(pb, "jcmd-symboltable");
> 93:         output.shouldContain("17 3: jdk/test/lib/apps\n");  // 3 because as a TempSymbol will be found in the TempSymbolCleanupDelayer queue
> 94:                    // note we might want to drain the queue before CDS dumps but this is correct for now, unless the queue length changes.

nit typo: s/3 because as a TempSymbol/3 because a TempSymbol/

Probably should end L93 with a period and s/note/Note/ on L94.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16954#pullrequestreview-1762958451
PR Review Comment: https://git.openjdk.org/jdk/pull/16954#discussion_r1414214565