RFR: 8321276: runtime/cds/appcds/dynamicArchive/DynamicSharedSymbols.java failed with "'17 2: jdk/test/lib/apps ' missing from stdout/stderr" [v2]

Daniel D. Daugherty dcubed at openjdk.org
Mon Dec 4 17:56:39 UTC 2023


On Mon, 4 Dec 2023 17:21:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this trivial change to fix the test to expect that the TempSymbol refcount is 1 more than expected.  The symbol is cached in [JDK-8315559](https://bugs.openjdk.org/browse/JDK-8315559) Delay TempSymbol cleanup to avoid symbol table churn.
>> 
>> A late change in the review removed draining the queue periodically, which caused this test failure.
>> Tested locally.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added punctuation and fixed typo, thanks Dan.

Still thumbs up.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16954#pullrequestreview-1763054037


More information about the hotspot-runtime-dev mailing list