Integrated: 8321183: Incorrect warning from cds about the modules file

Maxim Kartashev mkartashev at openjdk.org
Tue Dec 5 17:19:46 UTC 2023


On Fri, 1 Dec 2023 15:52:11 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

> When the `modules`  file used at run time differs in size from the one used at build time, the warning is confusing:
> 
> 
> $ .../bin/java -jar .../demo/jfc/Notepad/Notepad.jar
> [0.033s][warning][cds] A jar file is not the one used while building the shared archive file: /.../lib/modules
> [0.033s][warning][cds] A jar file is not the one used while building the shared archive file: /.../lib/modules
> [0.033s][warning][cds] /.../lib/modules timestamp has changed. 
> 
> Notice that it is referred to as `jar file` and that `timestamp has changed` rather than size.
> 
> The suggested patch is pretty self-explanatory. With this patch, the warnings look like this:
> 
> ./build/linux-x86_64-server-release/images/jdk/bin/java -jar ./build/linux-x86_64-server-release/images/jdk/demo/jfc/Notepad/Notepad.jar
> [0.014s][warning][cds] This file is not the one used while building the shared archive file: /home/maxim/openjdk/jdk/build/linux-x86_64-server-release/images/jdk/lib/modules
> [0.014s][warning][cds] This file is not the one used while building the shared archive file: /home/maxim/openjdk/jdk/build/linux-x86_64-server-release/images/jdk/lib/modules
> [0.014s][warning][cds] /home/maxim/openjdk/jdk/build/linux-x86_64-server-release/images/jdk/lib/modules size has changed.

This pull request has now been integrated.

Changeset: fd31f6a1
Author:    Maxim Kartashev <mkartashev at openjdk.org>
Committer: Calvin Cheung <ccheung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/fd31f6a1663de0e06accdf015a71086346aa0d98
Stats:     30 lines in 5 files changed: 10 ins; 8 del; 12 mod

8321183: Incorrect warning from cds about the modules file

Reviewed-by: ccheung, iklam

-------------

PR: https://git.openjdk.org/jdk/pull/16926


More information about the hotspot-runtime-dev mailing list