RFR: 8302790: Set FileMapRegion::mapped_base() to null if mapping fails [v3]
Calvin Cheung
ccheung at openjdk.org
Thu Dec 7 17:22:20 UTC 2023
On Fri, 1 Dec 2023 21:56:29 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> For cleanliness, we should reset FileMapRegion::mapped_base() to nullptr in case the mapping fails for any reasons. This patch moves the `set_mapped_base()` call after all the checks complete so it can remain as null in case checks fail. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into mapped_base_8302790
> - Used consistent pattern
> - Merge branch 'master' into mapped_base_8302790
> - Moved assignment after checks
> - 8302790: Set FileMapRegion::mapped_base() to null if mapping fails
Looks good. Thanks!
-------------
Marked as reviewed by ccheung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16866#pullrequestreview-1770669441
More information about the hotspot-runtime-dev
mailing list