RFR: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 [v2]

[David Holmes]

On Thu, 7 Dec 2023 19:35:55 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This test needs to be updated with each release since the release build number is hard coded. Now that the test has to download and install more JDKs, it will take longer to run and may timeout. A longer timeout is added as well as a minor correction where an exception was not being thrown.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed check for invalid JDK version

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 94:

> 92:                 doTest();
> 93:             } catch (RuntimeException e) {
> 94:                 throw new RuntimeException("Invalid AutoCreateSharedArchive JDK version: " + versions[i]);

If catching a general exception here you should now add that as the cause of the new one.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 133:

> 131:                                       "previous version of the JDK that supports " +
> 132:                                       "-XX:+AutoCreateSharedArchive");
> 133:         }

This code duplicates what is above.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17005#pullrequestreview-1771157739
PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1419678955
PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1419680256