RFR: 8321474: TestAutoCreateSharedArchiveUpgrade.java should be updated with JDK 21 [v3]

[David Holmes]

On Fri, 8 Dec 2023 17:10:35 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This test needs to be updated with each release since the release build number is hard coded. Now that the test has to download and install more JDKs, it will take longer to run and may timeout. A longer timeout is added as well as a minor correction where an exception was not being thrown.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed duplicate code and restored exception

Functional change seems fine. Two minor nits to fix before integration please.

Thanks

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 93:

> 91:                 setupJVMs(Integer.parseInt(versions[i]));
> 92:                 doTest();
> 93:             } catch (NumberFormatException  e) {

Extra space has been introduced before `e`

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 119:

> 117:             throw new SkippedException("Use -Dtest.previous.jdk or -Dtest.boot.jdk to specify a " +
> 118:                                       "previous version of the JDK that supports " +
> 119:                                       "-XX:+AutoCreateSharedArchive");

Revert these lines to restore the indent please.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17005#pullrequestreview-1774291058
PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1421948110
PR Review Comment: https://git.openjdk.org/jdk/pull/17005#discussion_r1421948807