RFR: 8321683: Tests fail with AssertionError in RangeWithPageSize
Stefan Karlsson
stefank at openjdk.org
Mon Dec 11 18:24:45 UTC 2023
The test was recently changed to check the THPeligible value in the smaps file, instead of checking the hg flag. This was done because hg isn't set if the THP policy is set to 'always'. With that change I added an assert that if the "hg" flag is set, then THPeligible should also be set. This turns out to not be true, and the assert fails.
My proposal is to check both properties and set isTHP to true if either is set. The isTHP property is later only used to make the page size checks more lenient in the presence of transparent huge pages.
-------------
Commit messages:
- 8321683: Tests fail with AssertionError in RangeWithPageSize.<init>(TestTracePageSizes.java:373)
Changes: https://git.openjdk.org/jdk/pull/17064/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17064&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8321683
Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/17064.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17064/head:pull/17064
PR: https://git.openjdk.org/jdk/pull/17064
More information about the hotspot-runtime-dev
mailing list