RFR: 8320317: ObjectMonitor NotRunnable is not really an optimization

[Fredrik Bredberg]

On Mon, 11 Dec 2023 09:50:37 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

> The performance on stable / reproducible performance tests increase with up to 12% on x86 based platforms if we remove ObjectMonitor::NotRunnable(). The performance decrease seen on AArch64 based macOS can be fixed by implementing SpinPause() (see: JDK-8321371).
> 
> This PR removes ObjectMonitor::NotRunnable().
> 
> Tested successfully on tier1-tier5.

Thanks for the review guys. But I don't want to integrate it before the SpinPause() discussions in https://github.com/openjdk/jdk/pull/16994 is resolved, because that would lead to a regression on AArch64 based MacOSX.

As soon as I feel more confident working in this code base I will try to add some salty comments, it certainly does adds some enjoyment to the source code reading experience. It also makes you remember the code better, which is always a good thing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17050#issuecomment-1853749686