RFR: JDK-8321975: Print when add_reserved_region fails even in product mode
Thomas Stuefe
stuefe at openjdk.org
Fri Dec 15 09:27:43 UTC 2023
On Wed, 13 Dec 2023 11:58:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Hi,
>
> We recently had a user e-mail hotspot-dev about a JVM crash which hit `ShouldNotReachHere` in `add_reserved_region`. As the logging is disabled in product builds the user couldn't supply us with all of the available information, quite unfortunate for us. I propose that we print the region information unconditionally and print the stacks also.
+1
good to push. I would like it if the printing were contained in something like VirtualMemoryRegion::print_on().
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17086#pullrequestreview-1783441045
More information about the hotspot-runtime-dev
mailing list