RFR: 8315462: [REDO] runtime/NMT/SummarySanityCheck.java failed with "Total committed (MMMMMM) did not match the summarized committed (NNNNNN)" [v5]

[Thomas Stuefe]

On Fri, 17 Nov 2023 13:12:48 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> This is a PR for the [original PR](https://github.com/openjdk/jdk/pull/16237).
>
> Afshin Zafari has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch '___8315462' of http://github.com/afshin-zafari/jdk into ___8315462
>  - Removed  the code that brought by merge.

Changes requested by stuefe (Reviewer).

src/hotspot/share/nmt/mallocTracker.hpp line 58:

> 56:   MemoryCounter() : _count(0), _size(0), _peak_count(0), _peak_size(0) {}
> 57: 
> 58:   inline void set_size_and_count(size_t size, size_t count) { _size = size; _count = count; }

It occurred to me that this invalidates the peak counter. You need to update that too, e.g.


void set_size_and_count(size_t size, size_t count) { 
  _size = size;
  _count = count;
  update_peak(size, count);
}

-------------

PR Review: https://git.openjdk.org/jdk/pull/16262#pullrequestreview-1783601532
PR Review Comment: https://git.openjdk.org/jdk/pull/16262#discussion_r1427846380