RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]

Jaikiran Pai jpai at openjdk.org
Mon Dec 18 10:24:08 UTC 2023


On Fri, 15 Dec 2023 06:08:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - David's review comments - reduce if blocks and release the array outside if block
>>  - David's review comment - punctuation
>
> src/hotspot/os/posix/perfMemory_posix.cpp line 612:
> 
>> 610:       continue;
>> 611:     }
>> 612:     FREE_C_HEAP_ARRAY(char, filename);
> 
> If you move this to immediately after lstat then you don't need it in the if-block

Thank you David for these inputs; they were useful. I've updated the PR to use those suggestions. Locally tests continue to pass. I've triggered CI testing with these new changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17104#discussion_r1429865689


More information about the hotspot-runtime-dev mailing list