Integrated: 8321933: TestCDSVMCrash.java spawns two processes

Matias Saavedra Silva matsaave at openjdk.org
Mon Dec 18 17:08:50 UTC 2023


On Wed, 13 Dec 2023 20:40:02 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> TestCDSVMCrash.java looks like it spawns two processes, once in the pb.start() call and then again in executeAndLog:
> 
>          OutputAnalyzer output = new OutputAnalyzer(pb.start());
>          // executeAndLog should throw an exception in the VM crashed
>          try {
>             CDSTestUtils.executeAndLog(pb, "cds_vm_crash");
> 
> The test redundantly checks the result of the output since the expected exception will only be thrown if the checked conditions are true.
> 
> Note that fixing the indentation makes the diff hard to read, so I recommend looking at each commit separately.

This pull request has now been integrated.

Changeset: 1fde8b86
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1fde8b868a0e40fb79de505106ef07e3dccbd1de
Stats:     33 lines in 1 file changed: 1 ins; 6 del; 26 mod

8321933: TestCDSVMCrash.java spawns two processes

Reviewed-by: ccheung, iklam

-------------

PR: https://git.openjdk.org/jdk/pull/17092


More information about the hotspot-runtime-dev mailing list