RFR: 8321683: Tests fail with AssertionError in RangeWithPageSize [v2]

[Stefan Karlsson]

On Tue, 19 Dec 2023 13:17:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add support for missing THPEligible
>
> As Arno mentioned, we need a workaround for older kernels. "THPeligible" has been introduced with linux 5.0. Older kernels won't have that thing.
> 
> Also, there has been a back and forth of patches that change the alignment of the output. So, make sure we work with `THPeligible: <any number of spaces> 1`.
> 
> Other than that, this is good. Scanning for both hg and THPeligible covers almost all cases. 
> 
> I don't know why we used !HT. Does not seem to make much sense.

Thanks @tstuefe and @ArnoZeller for the feedback around older kernels.

> As Arno mentioned, we need a workaround for older kernels. "THPeligible" has been introduced with linux 5.0. Older kernels won't have that thing.

I've added a null check, but I don't have a < 5.0 kernel readily available so it would be good if you could test this (if you have such a set up available).

> 
> Also, there has been a back and forth of patches that change the alignment of the output. So, make sure we work with `THPeligible: <any number of spaces> 1`.

I think the `\\s+` should handle those cases.

> 
> Other than that, this is good. Scanning for both hg and THPeligible covers almost all cases.
> 
> I don't know why we used !HT. Does not seem to make much sense.

Hopefully these changes covers enough for our testing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17064#issuecomment-1867637276