RFR: 8321683: Tests fail with AssertionError in RangeWithPageSize [v2]

Matthias Baesken mbaesken at openjdk.org
Fri Dec 22 13:03:38 UTC 2023


On Fri, 22 Dec 2023 12:35:04 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The test was recently changed to check the THPeligible value in the smaps file, instead of checking the hg flag. This was done because hg isn't set if the THP policy is set to 'always'. With that change I added an assert that if the "hg" flag is set, then THPeligible should also be set. This turns out to not be true, and the assert fails.
>> 
>> My proposal is to check both properties and set isTHP to true if either is set. The isTHP property is later only used to make the page size checks more lenient in the presence of transparent huge pages.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add support for missing THPEligible

Marked as reviewed by mbaesken (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17064#pullrequestreview-1794450376


More information about the hotspot-runtime-dev mailing list