RFR: 8321683: Tests fail with AssertionError in RangeWithPageSize [v3]

Stefan Karlsson stefank at openjdk.org
Fri Dec 22 13:29:15 UTC 2023


> The test was recently changed to check the THPeligible value in the smaps file, instead of checking the hg flag. This was done because hg isn't set if the THP policy is set to 'always'. With that change I added an assert that if the "hg" flag is set, then THPeligible should also be set. This turns out to not be true, and the assert fails.
> 
> My proposal is to check both properties and set isTHP to true if either is set. The isTHP property is later only used to make the page size checks more lenient in the presence of transparent huge pages.

Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:

  Typo

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17064/files
  - new: https://git.openjdk.org/jdk/pull/17064/files/cecabbdf..a40efc3f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17064&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17064&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17064.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17064/head:pull/17064

PR: https://git.openjdk.org/jdk/pull/17064


More information about the hotspot-runtime-dev mailing list