RFR: 8322747: StringTable should be AllStatic

Kim Barrett kbarrett at openjdk.org
Sun Dec 31 17:29:44 UTC 2023


On Sat, 30 Dec 2023 19:07:45 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> Please review this trivial change to StringTable, making it derive from
>> AllStatic rather than CHeapObj<mtSymbol>, to match the implementation.
>> 
>> While I was there, also did a little cleanup of related forward and friend
>> declarations.  StringTableCreateEntry doesn't exist.  Don't need forward
>> declaration for StringTable right before it's definition.  StringTable doesn't
>> need to befriend Symbol.
>> 
>> Testing: mach5 tier1
>
> ...and it looks trivial; ship it.

Thanks for the review, @fisk

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17193#issuecomment-1873000422


More information about the hotspot-runtime-dev mailing list